[ntuple] rename 'leaf' structural role to 'plain' #19502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jblomer
force-pushed
the
ntuple-rename-leaf
branch
2 times, most recently
from
74816d1 to
b5897c4
Compare
Test Results 21 files 21 suites 3d 9h 33m 4s ⏱️ For more details on these failures, see this check. Results for commit 0b31cde. ♻️ This comment has been updated with latest results. |
jblomer
force-pushed
the
ntuple-rename-leaf
branch
from
b5897c4 to
133130d
Compare
silverweed
reviewed
Aug 4, 2025
pcanal
reviewed
Aug 4, 2025
jblomer
force-pushed
the
ntuple-rename-leaf
branch
from
133130d to
174de14
Compare
jblomer
changed the title
jblomer
force-pushed
the
ntuple-rename-leaf
branch
from
174de14 to
37bd740
Compare
jblomer
force-pushed
the
ntuple-rename-leaf
branch
from
37bd740 to
d541b57
Compare
The name 'plain field' should better describe the actual structural role (resp. the absence of a structural role) of these fields. No change to the on-disk data.
jblomer
force-pushed
the
ntuple-rename-leaf
branch
from
d541b57 to
0b31cde
Compare
The structural role "leaf" was ill-named because in the tree of fields also inner nodes can carry that role. Hence renamed to "plain". Plain nodes are either leaves or they are inner "wrapper fields" with exactly one child field of the same cardinality (same number of elements modulo field repetition).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No changes to the on-disk format.